[PATCH] D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 23:43:06 PDT 2020


grimar added inline comments.


================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:183
+    return this->addValue(DT_SONAME, StrTab.Content.getOffset(SOName));
+  }
+  size_t getSize() const {
----------------
It is not clear why these e methods are needed? You could just call `addValue` on the caller side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89432/new/

https://reviews.llvm.org/D89432



More information about the llvm-commits mailing list