[PATCH] D87832: [IndVars] Remove monotonic checks with unknown exit count

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 21:26:16 PDT 2020


mkazantsev added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:956
+  /// of LHS `Pred` RHS.
+  bool isLoopInvariantPredicateAtDuringFirstIterations(
+      ICmpInst::Predicate Pred, const SCEV *LHS, const SCEV *RHS, const Loop *L,
----------------
apilipenko wrote:
> Style. Suggest to drop At from the name so as to make it more readable `isLoopInvariantPredicateDuringFirstIterations`.
No. `At` here means that this predicate is not true everywhere, but at specific point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87832/new/

https://reviews.llvm.org/D87832



More information about the llvm-commits mailing list