[PATCH] D90107: [TableGen] [AMDGPU] Add !sub bang operator for subtraction

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 09:36:17 PDT 2020


Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/test/TableGen/arithmetic.td:29
 
 def A0 : A<63, 1>;
+
----------------
foad wrote:
> Nit: choose two numbers for which !sub and !xor give different results? And preferably !srl and !sra too.
Good idea. I will do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90107/new/

https://reviews.llvm.org/D90107



More information about the llvm-commits mailing list