[PATCH] D90115: [LoopDeletion] Remove dead loops with no exit blocks

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 02:45:15 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopInfoImpl.h:139
+template <class BlockT, class LoopT>
+bool LoopBase<BlockT, LoopT>::hasNoExitBlocks() const {
+  SmallVector<BlockT *, 8> UniqueExitBlocks;
----------------
I'd put this directly after `getExitBlocks()`,
and potentially use `getExitBlocks()`, not `getUniqueExitBlocks()`,
since uniqification won't really affect the existence of said blocks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90115/new/

https://reviews.llvm.org/D90115



More information about the llvm-commits mailing list