[PATCH] D79141: [RISCV] Better Split Stack Pointer Adjustment for RVC

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 24 15:18:51 PDT 2020


lenary added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.h:60
 
-  // Get the first stack adjustment amount for SplitSPAdjust.
-  // Return 0 if we don't want to to split the SP adjustment in prologue and
-  // epilogue.
-  uint64_t getFirstSPAdjustAmount(const MachineFunction &MF) const;
+  /**
+   * Returns if we want to adjust the SP in two adjustments in the prolog and
----------------
asb wrote:
> Should use a C++ style comment
Actually I want to keep this as a doc comment, given it's in the header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79141/new/

https://reviews.llvm.org/D79141



More information about the llvm-commits mailing list