[PATCH] D90001: [llvm/DebugInfo] Emit DW_OP_implicit_value when tuning for LLDB
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 20:54:06 PDT 2020
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM with a few nits.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2483-2484
} else if (Value.isConstantFP()) {
- if (AP.getDwarfVersion() >= 4 && AP.getDwarfDebug()->tuneForGDB()) {
+ if (AP.getDwarfVersion() >= 4 && (AP.getDwarfDebug()->tuneForGDB() ||
+ AP.getDwarfDebug()->tuneForLLDB())) {
DwarfExpr.addConstantFP(Value.getConstantFP()->getValueAPF(), AP);
----------------
================
Comment at: llvm/test/DebugInfo/X86/implicit_value-float.ll:12
+; RUN: llc -debugger-tune=lldb -filetype=obj %s -o - | llvm-dwarfdump - | FileCheck %s
+
----------------
Maybe add a negative test for sce?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90001/new/
https://reviews.llvm.org/D90001
More information about the llvm-commits
mailing list