[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 18:34:52 PDT 2020


nickdesaulniers added a comment.

I missed adding to llvm/lib/Bitcode/Reader/BitcodeReader.cpp, so LTO is broken with this fn attribute...todo...fix

  diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  index f8069b93103f..a99d6baa8d9d 100644
  --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  @@ -1537,6 +1537,8 @@ static Attribute::AttrKind getAttrFromCode(uint64_t Code) {
       return Attribute::ByRef;
     case bitc::ATTR_KIND_MUSTPROGRESS:
       return Attribute::MustProgress;
  +  case bitc::ATTR_KIND_NO_STACK_PROTECT:
  +    return Attribute::NoStackProtect;
     }
   }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87956/new/

https://reviews.llvm.org/D87956



More information about the llvm-commits mailing list