[PATCH] D85928: [libFuzzer] Added -print_full_coverage flag.

[Max Moroz via Phabricator via llvm-commits]

Dor1s added a comment.

Not that I like to merge CLs on Friday afternoon, but I'm OOO next week, so taking a shot now while I'm still online.



================
Comment at: compiler-rt/lib/fuzzer/FuzzerTracePC.cpp:304
+    if (PrintAllCounters) {
+      if (UncoveredPCs.size() > 0) {
+        Printf("U");
----------------
morehouse wrote:
> Dor1s wrote:
> > mbarbella-chromium wrote:
> > > Dor1s wrote:
> > > > morehouse wrote:
> > > > > Do we need to exclude the U and C when the vectors are empty?  It's slightly cleaner to exclude these if-statements.
> > > > I think it depends on the consuming side. Marty, what do you think?
> > > This should be easy enough to handle, though it may need a small update to the training script. I agree that it's cleaner to output them unconditionally, but I don't have strong feelings either way.
> > I think leaving this is-is would be slightly better, as at least from the user perspective it'd be explicit that this code was executed and the counters were empty.
> Leaving as-is actually leaves it a mystery whether this code was executed or not.  I was suggesting printing the U and C unconditionally (removing the if statements).
My bad, let me remove the conditions then. Thanks for clarifying this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85928/new/

https://reviews.llvm.org/D85928