[PATCH] D88988: [llvm-symbolizer] Add inline stack traces for Windows.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I'd like to be able to test this code more thoroughly. Take a look at llvm/test/DebugInfo/symbolize-paths.s. Can we construct a similar test with an assembly file? What would it take to get that set up? That would allow us to write tests with really fine grained control over the .cv_loc positioning, so we could test all the edge cases for what happens when you symbolize a PC that falls in a gap in an inline call site.



================
Comment at: llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp:70
+      CodeOffset += Annot.U1;
+      if (OffsetInFunc >= CodeOffset)
+        Found = true;
----------------
rnk wrote:
> I wonder if this should be `>` instead of `>=`. Consider the case of:
>   callq somewhere
>   .cv_loc ... inline location
>   nop # anything
> 
> Otherwise, this seems like it should work to me.
Any thoughts on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88988/new/

https://reviews.llvm.org/D88988