[PATCH] D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections

[Haowei Wu via Phabricator via llvm-commits]

haowei marked 17 inline comments as done.
haowei added inline comments.


================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:389
     writeShdr(Data, StrTab);
+    writeShdr(Data, DynSym);
+    writeShdr(Data, DynTab);
----------------
MaskRay wrote:
> Usually linkers place .dynsym .dynstr before .strtab .shstrtab .symtab
> 
> The source order does not reflect the actual order and can cause confusion
I have reordered the section headers. The StrTab here is actually .dynstr since a stub SO does not need .strtab .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89432/new/

https://reviews.llvm.org/D89432