[PATCH] D90041: [AIX][cmake] Adjust management of `-G` for linking
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 11:34:01 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/CMakeLists.txt:939
+ # with plugins.
+ string(APPEND CMAKE_MODULE_LINKER_FLAGS " -shared -Wl,-G")
----------------
daltenty wrote:
> An aside: we should consider if this is worth mentioning to upstream CMake.
@daltenty, this is building on your prior work to reduce the run-time linking exposure. It seems upstream CMake does understand the need on AIX for `-shared -Wl,-G` for non-XL and `-G` for XL when the intent is to use run-time linking. That is, out-of-the-box, I think CMake works if we were happy with the run-time linking. It seems the ability for a user to communicate the run-time linking intent in terms of CMake may be where there is a gap.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90041/new/
https://reviews.llvm.org/D90041
More information about the llvm-commits
mailing list