[PATCH] D90056: [AutoFDO] Remove a broken assert in merging inlinee samples

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

LGTM. The assertion is indeed fragile. I can think of another case to break the assertion. getEntrySamples depends on what is the first source line or the callsite in the inline instance. Suppose a FunctionSample is duplicated so initally getEntrySamples value of all duplicates are all equal. However it is easy for the value of getEntrySamples to change after some optimization changes the first line/callsite in a duplicate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90056/new/

https://reviews.llvm.org/D90056