[PATCH] D90041: [AIX][cmake] Adjust management of `-G` for linking

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.

LGTM, thanks!



================
Comment at: llvm/CMakeLists.txt:939
+  # with plugins.
+  string(APPEND CMAKE_MODULE_LINKER_FLAGS " -shared -Wl,-G")
 
----------------
An aside: we should consider if this is worth mentioning to upstream CMake.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:94
+    # FIXME: `-Wl,-bE:` bypasses whatever handling there is in the build
+    # compiler driver to defer to the specified export list.
     set(native_export_file "${export_file}")
----------------
Just an aside note, very recent version of CMake on AIX now write their own export lists. When this gets fixed, it would also be good to check the interactions with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90041/new/

https://reviews.llvm.org/D90041