[PATCH] D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD

Fri Oct 23 09:00:28 PDT 2020

MaskRay added a comment.

In D85994#2219062 <https://reviews.llvm.org/D85994#2219062>, @MaskRay wrote:

> First, if this issue is not common enough, I'd rather we don't have a diagnostic at all.
>
> If we do need it, note that `*(i - 2);` may be out of bounds.
>
> Last, we should avoid pre-built object files. You can synthesize them with yaml2obj. The preferred style is `llvm/test/tools/llvm-readobj/ELF/*.test`. lld/test/ELF has some yaml2obj tests as well.

@stefanp The error turns out to be a problem when building glibc.

elf/dl-sym.c has a raw `__tls_get_addr` call (it sets up the parameter by itself), without R_PPC64_TLSGD/R_PPC64_TLSLD (similar to `CallOnly`). Shall we drop the logic?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85994/new/

https://reviews.llvm.org/D85994