[PATCH] D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

LGTM. A few nit comments. Please check that check-clang also passes (since you changed a shared file, OMP.td).



================
Comment at: flang/test/Semantics/omp-default.f90:4
+! 2.15.3.1 default Clause
+program omp_default
+  integer :: a(10), b(10), c(10),i,k
----------------
Nit: Please add a positive test as well.


================
Comment at: flang/test/Semantics/omp-default.f90:14
+  !ERROR: At most one DEFAULT clause can appear on the TASK directive
+  !$omp task default(shared), default(none),shared(a,b,c,k,i)
+  do i = 1, 10
----------------
Nit: space before shared.


================
Comment at: flang/test/Semantics/omp-default.f90:28
+  !ERROR: At most one DEFAULT clause can appear on the TEAMS directive
+  !$omp teams default(shared), default(none),shared(i,a,b,k,c)
+  do i = 1, 10
----------------
Nit: space before shared.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89861/new/

https://reviews.llvm.org/D89861