[PATCH] D78568: [DAGCombine] Fix bug in load scalarization

Fri Oct 23 08:29:38 PDT 2020

foad added a comment.

In D78568#2350291 <https://reviews.llvm.org/D78568#2350291>, @frasercrmck wrote:

> In D78568#2349707 <https://reviews.llvm.org/D78568#2349707>, @foad wrote:
>
>> Looks good to me. You could pre-commit the test case and rebase this diff so we can see the effect on codegen.
>
> Sure, I can do that. Is committing a test that "expects" incorrect codegen the done thing?

Yes, especially if it's only temporary and the checks are generated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78568/new/

https://reviews.llvm.org/D78568