[PATCH] D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct

Fri Oct 23 08:26:29 PDT 2020

awarzynski added inline comments.

================
Comment at: flang/lib/Lower/OpenMP.cpp:112
+              genObjectList(*ompObjectList, converter, operandRange);
+            if (auto &flushMemoryClause = std::get<
+                    std::optional<Fortran::parser::OmpFlushMemoryClause>>(
----------------
SouraVX wrote:
> kiranchandramohan wrote:
> > Is this variable used? Would it give a warning and cause a failure in the Werror enabled bots?
> Yes the warning comes and failure may happen. But nobody mentioned this on `FIR-dev` ?
> But let me reconfirm? is this flag `Werror` enabled by default on all `LLVM bots` ? if so let me remove this.
Two out three of our buildbots have `Werror` enabled for Flang: 
* https://github.com/llvm/llvm-zorg/blob/e8ba87e92b857c14b7eb5466c4266a9e09a1f5fb/buildbot/osuosl/master/config/builders.py#L1515-L1558

As you can see one uses `clang-10` and the other `gcc-10`. Hope this helps!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90048/new/

https://reviews.llvm.org/D90048