[PATCH] D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 08:14:43 PDT 2020


SouraVX added inline comments.


================
Comment at: flang/lib/Lower/OpenMP.cpp:112
+              genObjectList(*ompObjectList, converter, operandRange);
+            if (auto &flushMemoryClause = std::get<
+                    std::optional<Fortran::parser::OmpFlushMemoryClause>>(
----------------
kiranchandramohan wrote:
> Is this variable used? Would it give a warning and cause a failure in the Werror enabled bots?
Yes the warning comes and failure may happen. But nobody mentioned this on `FIR-dev` ?
But let me reconfirm? is this flag `Werror` enabled by default on all `LLVM bots` ? if so let me remove this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90048/new/

https://reviews.llvm.org/D90048



More information about the llvm-commits mailing list