[PATCH] D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 07:30:08 PDT 2020
clementval added a comment.
In D89546#2349857 <https://reviews.llvm.org/D89546#2349857>, @yhegde wrote:
> 2. RequiresPositiveParameter() function is not called, because with the custom implementation we can give specific error message pointing to invalid chunk size. If we use that function we will end up in throwing generic error message.
Fair enough. What about modifying `RequiresPositiveParameter()` to take optional custom error message so we can share the code?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89546/new/
https://reviews.llvm.org/D89546
More information about the llvm-commits
mailing list