[PATCH] D89892: [AsmPrinter] Add per BB instruction mix remark.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 300264.
fhahn marked an inline comment as done.
fhahn added a comment.

Thanks for all the comments. Updated to use MBB.empty().

In D89892#2349185 <https://reviews.llvm.org/D89892#2349185>, @thegameg wrote:

> In D89892#2349184 <https://reviews.llvm.org/D89892#2349184>, @anemet wrote:
>
>> How about adding a total count as well?  That should help quickly eye ball the ratios.
>
> Wouldn't that overlap with the `InstructionCount` remark?

I think so. Or do you mean per instruction counts for the whole function? That could also be done by post-processing I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89892/new/

https://reviews.llvm.org/D89892

Files:
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/test/CodeGen/AArch64/arm64-instruction-mix-remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89892.300264.patch
Type: text/x-patch
Size: 5106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201023/b7fbe82d/attachment.bin>