[PATCH] D78568: [DAGCombine] Fix bug in load scalarization

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 05:01:55 PDT 2020


foad added a comment.

Looks good to me. You could pre-commit the test case and rebase this diff so we can see the effect on codegen.



================
Comment at: llvm/test/CodeGen/AMDGPU/extract_load_i1.ll:1
+; RUN: llc -mtriple=amdgcn-amd-amdhsa < %s | FileCheck %s
+
----------------
Generate the checks with utils/update_llc_test_checks.py? It looks like you might have done that already, except that it should leave a comment on line 1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78568/new/

https://reviews.llvm.org/D78568



More information about the llvm-commits mailing list