[PATCH] D88983: [NFCI] Replace AArch64StackOffset by StackOffset.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 04:25:07 PDT 2020
sdesmalen marked an inline comment as done.
sdesmalen added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1944
-AFI->getCalleeSaveBaseToFrameRecordOffset();
- StackOffset FPOffset = StackOffset(OffsetFromFPToSVEArea, MVT::i8) +
- StackOffset(ObjectOffset, MVT::nxv1i8);
+ StackOffset FPOffset = StackOffset::getFixed(OffsetFromFPToSVEArea) +
+ StackOffset::getScalable(ObjectOffset);
----------------
david-arm wrote:
> It's just a thought, but in cases such as this where we're initialising to a composite we could replace the addition with:
>
> StackOffset::get(OffsetFromFPToSVEArea, ObjectOffset)
Good catch!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88983/new/
https://reviews.llvm.org/D88983
More information about the llvm-commits
mailing list