[PATCH] D90019: [yaml2obj] - Add a way to override the sh_addralign field of a section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 03:49:10 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/override-shaddralign.yaml:39-41
+  - Name:    .dynsym
+    Type:    SHT_DYNSYM
+    [[KEY]]: 0x1111111111111111
----------------
jhenderson wrote:
> I don't understand why we need multiple different kinds of sections. This is generic behaviour, so doesn't need testing with everything, right?
Yes, though we do it for `ShName` , `ShOffset` and `ShSize`. I mostly wanted to be consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90019/new/

https://reviews.llvm.org/D90019



More information about the llvm-commits mailing list