[PATCH] D89991: [AliasAnalysis] Fix a bug in alias analysis interaction with CSE w/ memorySSA

Fri Oct 23 02:24:45 PDT 2020

haoranxu510 added a comment.

In D89991#2349360 <https://reviews.llvm.org/D89991#2349360>, @lebedev.ri wrote:

> Needs a test

Hi Roman,

Thanks for your comment! 
I'm new to LLVM, can you explain what test would be needed? So currently I have the C code snippet that is miscompiled before this diff and works after this diff, however, the snippet is ~100KB. Do you think it is OK to add a test like that?
I don't know the internals of LLVM so I don't know how I can construct a not-end-to-end failing case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89991/new/

https://reviews.llvm.org/D89991