[PATCH] D89995: Make the post-commit review expectations more explicit with respect to revert

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 01:57:23 PDT 2020


rengolin accepted this revision.
rengolin added a comment.

This is a great policy, thanks @silvas and @mehdi_amini.

LGTM with one small change (inline).



================
Comment at: llvm/docs/CodeReview.rst:57
+
+Before being recommitted, the patch generally undergoes further review,
+including by the community member who identified the problem and, in cases
----------------
I'd say "should undergo". The way it's written sounds like something that "happens" not something that "should happen".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89995/new/

https://reviews.llvm.org/D89995



More information about the llvm-commits mailing list