[PATCH] D89379: [llvm-readobj/libObject] - Allow dumping objects that has a broken SHT_SYMTAB_SHNDX section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 00:56:43 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbol-shndx.test:265
+
+#       SHNDX-ERR-GNU: warning: '[[FILE]]': SHT_SYMTAB_SHNDX has 3 entries, but the symbol table associated has 2
+# SHNDX-ERR-GNU-EMPTY:
----------------
jhenderson wrote:
> Presumably not part of this patch, since I can't see the error message being reported anywhere in the changes, but this should be "the associated symbol table".
Yeah. It comes from `ELFFile<ELFT>::getSHNDXTable`. I'll fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89379/new/

https://reviews.llvm.org/D89379



More information about the llvm-commits mailing list