[PATCH] D89797: [WebAssembly] Implementation of (most) table instructions

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 23:09:34 PDT 2020


pmatos added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenTarget.cpp:232
+  case MVT::externref:
+    return "MVT::externref";
   default: llvm_unreachable("ILLEGAL VALUE TYPE!");
----------------
sbc100 wrote:
> Maybe use the local style of putting these on single line?
I will do that but this was a lint suggested change, so I accepted it. I will revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89797/new/

https://reviews.llvm.org/D89797



More information about the llvm-commits mailing list