[PATCH] D89105: [X86] Support Intel avxvnni

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/Headers/avxvnniintrin.h:32
+#include "commonvnniintrin.h"
+
+/* Intrinsics with _avx_ prefix are for compatibility with msvc. */
----------------
pengfei wrote:
> Maybe we can move `commonvnniintrin.h` to `immintrin.h`. Then we don't have a different layout.
> ```
> #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      \
>      defined(__AVX512VNNI__) || (defined(__AVX512VL__) && defined(__AVX512VNNI__))
> #include <commonvnniintrin.h>
> #endif
> ```
gcc appears to have just put the common intrinsics in avxvnniintrin.h. Why can't we do that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105