[PATCH] D89921: [LLD] [COFF] Align all debug directories

[Petr Penzin via Phabricator via llvm-commits]

penzn added a comment.

In D89921#2346184 <https://reviews.llvm.org/D89921#2346184>, @vitalybuka wrote:

> do we need to update some tests?

Do you mean the tests that failed? I can't reproduce them yet.



================
Comment at: lld/COFF/Writer.cpp:951
   if (config->debug || config->repro || config->cetCompat) {
     debugDirectory = make<DebugDirectoryChunk>(debugRecords, config->repro);
     debugInfoSec->addChunk(debugDirectory);
----------------
rnk wrote:
> Can we make the DebugDirectoryChunk set the default alignment to 4 instead? I believe other chunks do that as well.
Let me try that.


================
Comment at: lld/COFF/Writer.cpp:976
+      if (r.second->getAlignment() < 4) 
+          r.second->setAlignment(4);
       debugInfoSec->addChunk(r.second);
----------------
vitalybuka wrote:
> now space alignment is broken :)
Ah, two spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89921/new/

https://reviews.llvm.org/D89921