[PATCH] D89889: [test] Simplify pr33641_remove_arg_dbgvalue.ll

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D89889#2348178 <https://reviews.llvm.org/D89889#2348178>, @rnk wrote:

>> The legacy PM pass ran passes on SCCs in a different order, causing
>> argpromotion to not trigger on @bar().
>
> I see, so DSE would run, then bar would become unreferenced, and then there would be no reason to promote arguments?

Actually, the legacy PM first ran passes on @foo(), then @bar() arbitrarily since it doesn't keep track of function references, only direct calls. In the NPM, it sees the reference of @bar() in @foo(), so properly first runs passes on @bar() then @foo().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89889/new/

https://reviews.llvm.org/D89889