[PATCH] D89105: [X86] Support Intel avxvnni

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/avxvnniintrin.h:31
+
+#include "commonvnniintrin.h"
+
----------------
RKSimon wrote:
> LiuChen3 wrote:
> > LiuChen3 wrote:
> > > RKSimon wrote:
> > > > Is having a commonvnniintrin.h header the approach gcc/icc are taking?
> > > GCC doesn't have commonvnniintrin.h headr, they only have avxvnniintrin.h. For ICC, I will check with this and give you answer later.
> > GCC and ICC doesn't break intrinsics into multiple headers.
> Is there anyway that we can avoid this as well then? I get worried when header layouts start to diverge...
Hi Simon, why we need to keep the same layout with GCC and ICC?
We always create new header files for new instructions. We don't allow user include these headers directly. So I think it doesn't matter if GCC and ICC create the same headers or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105