[PATCH] D89995: Make the post-commit review expectations more explicit with respect to revert
Sean Silva via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 16:47:33 PDT 2020
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Looks like my original proposal so LGTM. Please wait for some more folks to chime in though.
================
Comment at: llvm/docs/CodeReview.rst:55
+other development; it's entirely possible the patch will end up being reapplied
+essentially as is once concerns have been resolved.
+
----------------
What is this `!` that phab is showing in the UI? Looks like some non-ascii character?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89995/new/
https://reviews.llvm.org/D89995
More information about the llvm-commits
mailing list