[PATCH] D89415: [AArch64][GlobalISel] Introduce a new post-isel optimization pass

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostSelectOptimize.cpp:1
+//=== lib/CodeGen/GlobalISel/AArch64PostSelectOptimize.cpp --  ------------===//
+//
----------------
some weird whitespace there


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostSelectOptimize.cpp:161
+
+bool AArch64PostSelectOptimize::runOnMachineFunction(MachineFunction &MF) {
+  if (MF.getProperties().hasProperty(
----------------
Should this assert that the function has been selected?


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostSelectOptimize.cpp:167
+  bool Changed = false;
+  for (auto &BB : MF) {
+    Changed |= optimizeNZCVDefs(BB);
----------------
Remove braces?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89415/new/

https://reviews.llvm.org/D89415