[PATCH] D89216: [dsymutil] Add the ability to run the DWARF verifier on the input

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/tools/dsymutil/BinaryHolder.cpp:274
+    std::unique_ptr<DWARFContext> DICtx = DWARFContext::create(*Object);
+    if (!DICtx->verify(OS, DumpOpts.noImplicitRecursion()))
+      WithColor::warning() << "input verification failed for "
----------------
clayborg wrote:
> I believe that detection of overlapping address ranges is disabled or .o files since it is known to have unrelocated addresses. 
probably, yes. My point is that we can ignore errors, which could be cured by dsymutil, and we could stop verifying if the error, which could not be fixed by dsymutil, was met.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89216/new/

https://reviews.llvm.org/D89216