[PATCH] D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision.
sfertile added inline comments.


================
Comment at: lld/test/ELF/ppc64-tls-pcrel-ld.s:62
+LDAddr:
+  # TODO: This symbol is added to to ensure that this object has a .TOC. symbol.
+  # In this situation we have tls references that require the GOT but a valid
----------------
Minor nit: use '##' for comments.

I suggest tweaking the comment a bit:
```
Adding a reference to .TOC. since LLD doesn't gracefully handle the case where we define a .got section but have no references to
the toc base yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87504/new/

https://reviews.llvm.org/D87504