[PATCH] D87651: [AArch64][SVE] Implement extractelement of i1 vectors.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 12:49:06 PDT 2020


efriedma added a comment.

I'm worried the usage of ANY_EXTEND and TRUNCATE in D89950 <https://reviews.llvm.org/D89950> is going to cause a mess in the future.  LegalizeDAG doesn't know how to legalize most vector operations; LegalizeVectorOps handles them.  If someone tries to use "Promote" on a target where those operations aren't legal, it'll break.  And then someone will try to "fix" LegalizeDAG, and cause other problems.

Note this is specific to the vector operations we legalize in LegalizeDAG; so essentially, INSERT_VECTOR_ELT, EXTRACT_VECTOR_ELT, and VECTOR_SHUFFLE.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87651/new/

https://reviews.llvm.org/D87651



More information about the llvm-commits mailing list