[PATCH] D88988: [llvm-symbolizer] Add inline stack traces for Windows.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 12:46:50 PDT 2020
rnk added a comment.
In D88988#2343350 <https://reviews.llvm.org/D88988#2343350>, @akhuang wrote:
> It looks like the first frame on Windows doesn't even point to `GetCurrentPc`; it points to the call to `UnwindImpl`.
Well, from reading the code, I would expect PC to be the return address of `GetCurrentPc`, which points to the `xor %ecx, %ecx` instruction, which is not in the inline call site. The `.cv_inline_site_id` directive happens at the next instruction. Maybe there is a bug in the way this code compares against inline site begin/end markers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88988/new/
https://reviews.llvm.org/D88988
More information about the llvm-commits
mailing list