[PATCH] D89820: [AArch64][GlobalISel] Split post-legalizer combiner to allow for lowering at -O0

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 11:05:09 PDT 2020


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with comment fixes.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:563-564
 void AArch64PassConfig::addPreRegBankSelect() {
   // For now we don't add this to the pipeline for -O0. We could do in future
   // if we split the combines into separate O0/opt groupings.
   bool IsOptNone = getOptLevel() == CodeGenOpt::None;
----------------
Can remove this comment since it's now outdated.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp:15
+/// For example, this combiner will notice that a G_SHUFFLE_VECTOR is actually
+/// a G_ZIP, U_UZP, etc.
+///
----------------
s/U_UZP/G_UZP


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89820/new/

https://reviews.llvm.org/D89820



More information about the llvm-commits mailing list