[PATCH] D89707: [CSSPGO][llvm-profgen] Parse mmap events from perf script
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 10:16:06 PDT 2020
hoy added inline comments.
================
Comment at: llvm/tools/llvm-profgen/llvm-profgen.cpp:105
+ return true;
+ if (*P == '\r' && *(P + 1) == '\n')
+ return true;
----------------
wlei wrote:
> mtrofin wrote:
> > could P+1 be out of bounds?
> Yeah, it seems it's not used here, delete this!
The underlying `MemoryBuffer` ensures there is always trailing `\0` at the end.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89707/new/
https://reviews.llvm.org/D89707
More information about the llvm-commits
mailing list