[PATCH] D89826: [FunctionAttrs][NPM] Fix handling of convergent

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D89826#2346511 <https://reviews.llvm.org/D89826#2346511>, @efriedma wrote:

> At a high level, it should be fine to assume an indirect call without the "convergent" attribute isn't convergent.  If the language rules for some language say the callee of an indirect call might be convergent, the frontend can add the convergent attribute to that call.  (Unlike most attributes, it's a negative attribute: it restricts optimizations, and attribute inference optimizations would remove it,)

I don't object to that but I want us to remove the "may" from the lang ref and make it a "will" (or similar). It describes the semantics not the optimization we "may" perform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89826/new/

https://reviews.llvm.org/D89826