[PATCH] D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_load_in_loop.mir:83
     $rbp = MOV64rr $rdi, debug-location !17
+    DBG_VALUE $rbp, $noreg, !16, !DIExpression(), debug-location !17
     dead $rcx = MOV64ri 0, debug-location !17
----------------
djtodoro wrote:
> jmorse wrote:
> > djtodoro wrote:
> > > Why including this here?
> > /me squints; I think I moved this because otherwise the the output looks like this:
> > 
> >     DBG_VALUE $rdi
> >     $rbp = MOV64rr $rdi
> >     $rcx = MOV64ri 0
> >     CALL64pcrel32 @bees
> >     DBG_VALUE $rbp
> > 
> > i.e., the location is recovered to $rbp after the call clobbers $rdi. Wheras with this change, LiveDebugValues does not have to recover any clobbers.
> > 
> > My thinking was that, because this test is targeted at one thing VarLocBasedLDV does poorly, it's best to reduce the number of features being tested in the test, so that clobber being recovered from should be avoided.
> OK then :)
> 
> Does moving it into the previous change(D88405) make sense to you?
Yeah, I've got an intermediate patch to stick between the two that sorts these things out, I'm doing a little patch gardening first though., should appear shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88406/new/

https://reviews.llvm.org/D88406