[PATCH] D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 09:48:37 PDT 2020


SouraVX added a comment.

Thanks for the patch and adding the unit-test for the same. This API is still un-used(directly) (`classic flang` uses it's own way to construct this.).
The new `Flang` is the planned consumer for it, Although since most `CodeGen` part of new `Flang` is still lives downstream. There's not much we can do about it WRT to debug-info and these API utilization.

LGTM! I'll leave to @aprantl for official approval(since he's senior member and understands the API interfacing and debug metadata much better) :).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89817/new/

https://reviews.llvm.org/D89817



More information about the llvm-commits mailing list