[PATCH] D89890: [Docs] Clarify that FunctionPasses can't add/remove declarations

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D89890#2347728 <https://reviews.llvm.org/D89890#2347728>, @aeubanks wrote:

> Ideally they'd be module passes, like in https://reviews.llvm.org/D86178.
> It does look like some existing legacy and NPM function passes break this rule. Maybe I should revert and ask more explicitly on llvm-dev. WDYT?

I would bet the majority of passes do (e.g. InstCombine, and pretty much any target IR pass). In the past the guidance was adding declarations is OK (I thought last time this came up, this was noted somewhere in the documentation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89890/new/

https://reviews.llvm.org/D89890