[PATCH] D89969: [SLP] Consider alternatives for cost of select instructions.

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3553
+      Intrinsic::ID IID = -1;
+      // Check if the select can be folded into a min/max intrinsic and check if
+      // that is a cheaper alternative. Lowering to the actual intrinsics/target
----------------
Maybe add TODO to remove/adjust this code when LLVM starts using u/smin/max fully?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3568
+
+            Intrinsic::ID NewIID = -1u;
+            switch (Cmp->getPredicate()) {
----------------
intrinsic::not_intrinsic


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89969/new/

https://reviews.llvm.org/D89969