[PATCH] D89657: [gn build] Add missing clangd dependencies
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 09:04:45 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf3c51e3546e: [gn build] Add missing clangd dependencies (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89657/new/
https://reviews.llvm.org/D89657
Files:
llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
llvm/utils/gn/secondary/clang-tools-extra/clangd/quality/gen_decision_forest.gni
Index: llvm/utils/gn/secondary/clang-tools-extra/clangd/quality/gen_decision_forest.gni
===================================================================
--- llvm/utils/gn/secondary/clang-tools-extra/clangd/quality/gen_decision_forest.gni
+++ llvm/utils/gn/secondary/clang-tools-extra/clangd/quality/gen_decision_forest.gni
@@ -2,6 +2,11 @@
model = invoker.model
filename = invoker.filename
cpp_class = invoker.cpp_class
+ if (defined(invoker.deps)) {
+ extra_deps = invoker.deps
+ } else {
+ extra_deps = []
+ }
action("${target_name}Cpp") {
script = "//clang-tools-extra/clangd/quality/CompletionModelCodegen.py"
@@ -34,7 +39,7 @@
"//llvm/utils/gn/build:clang_code",
":${target_name}Config",
]
- deps = [ ":${target_name}Cpp" ]
+ deps = [ ":${target_name}Cpp" ] + extra_deps
include_dirs = [ "." ]
sources = get_target_outputs(":${target_name}Cpp")
}
Index: llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
+++ llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
@@ -25,6 +25,7 @@
model = "quality/model"
filename = "CompletionModel"
cpp_class = "clang::clangd::Example"
+ deps = [ "//clang/lib/Sema" ]
}
static_library("clangd") {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89657.300007.patch
Type: text/x-patch
Size: 1361 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201022/6c46d9c5/attachment.bin>
More information about the llvm-commits
mailing list