[PATCH] D89890: [Docs] Clarify that FunctionPasses can't add/remove declarations
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 09:04:12 PDT 2020
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG710676cf3a3c: [Docs] Clarify that FunctionPasses can't add/remove declarations (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89890/new/
https://reviews.llvm.org/D89890
Files:
llvm/docs/WritingAnLLVMPass.rst
Index: llvm/docs/WritingAnLLVMPass.rst
===================================================================
--- llvm/docs/WritingAnLLVMPass.rst
+++ llvm/docs/WritingAnLLVMPass.rst
@@ -474,7 +474,8 @@
To be explicit, ``FunctionPass`` subclasses are not allowed to:
#. Inspect or modify a ``Function`` other than the one currently being processed.
-#. Add or remove ``Function``\ s from the current ``Module``.
+#. Add or remove ``Function``\ s from the current ``Module``, including
+ declarations.
#. Add or remove global variables from the current ``Module``.
#. Maintain state across invocations of :ref:`runOnFunction
<writing-an-llvm-pass-runOnFunction>` (including global data).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89890.300006.patch
Type: text/x-patch
Size: 695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201022/9570f643/attachment.bin>
More information about the llvm-commits
mailing list