[PATCH] D89038: [PatternMatch] Add new FP matchers. NFC.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:616-620
+/// For vectors, this includes constants with undefined elements.
+inline cstfp_pred_ty<is_finite> m_Finite() {
+  return cstfp_pred_ty<is_finite>();
+}
+inline apf_pred_ty<is_finite> m_Finite(const APFloat *&V) { return V; }
----------------
lebedev.ri wrote:
> So if this is using `apf_pred_ty`, then this doesn't support `undef` constants then?
Correct. m_Finite() does, m_Finite(const APFloat *&) does not. This is the pre-existing problem I mentioned which has now been copied across from the integer matchers to the fp ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89038/new/

https://reviews.llvm.org/D89038