[PATCH] D89170: [AMDGPU] Select flat scratch instructions where available
Sebastian Neubauer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 07:59:26 PDT 2020
Flakebi added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:482
if (MFI->hasFlatScratchInit()) {
emitEntryFunctionFlatScratchInit(MF, MBB, I, DL, ScratchWaveOffsetReg);
----------------
Should this be `MFI->hasFlatScratchInit() || (ST.enableFlatScratch() && requiresStackPointerReference(MF))`?
Otherwise, the scratch does not get initialized (I guess it’s fine to do that in a later patch).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89170/new/
https://reviews.llvm.org/D89170
More information about the llvm-commits
mailing list