[PATCH] D88540: [AMDGPU] Add amdgpu_gfx_callable calling convention

Thu Oct 22 07:59:32 PDT 2020

nhaehnle added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:5090
   if (isMIMG(MI) ||
-      (AMDGPU::isShader(MF.getFunction().getCallingConv()) &&
-       (isMUBUF(MI) || isMTBUF(MI)))) {
+      ((ST.isAmdPalOS() || ST.isMesa3DOS()) && (isMUBUF(MI) || isMTBUF(MI)))) {
     MachineOperand *SRsrc = getNamedOperand(MI, AMDGPU::OpName::srsrc);
----------------
nhaehnle wrote:
> I believe this will break radeonsi because it actually ends up settings OS == unknown. We'll have to follow-up on that, but in the meantime, couldn't this use AMDGPU::isGraphics?
Okay, technically I suppose it shouldn't break radeonsi, but regress it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88540/new/

https://reviews.llvm.org/D88540