[PATCH] D89038: [PatternMatch] Add new FP matchers. NFC.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 22 07:40:13 PDT 2020
foad added inline comments.
================
Comment at: llvm/include/llvm/IR/PatternMatch.h:587
+/// Match a non-NaN FP constant.
+/// For vectors, this includes constants with undefined elements.
+inline cstfp_pred_ty<is_nonnan> m_NonNaN() {
----------------
RKSimon wrote:
> lebedev.ri wrote:
> > lebedev.ri wrote:
> > > I think i'd like to see some dedicated tests with `undef`s in `llvm/unittest/IR/PatternMatch.cpp`.
> > So does it or does it not allow undefs?
> AFAICT cstfp_pred_ty supports vectors with undef elements but apf_pred_ty doesnot
It allows undefs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89038/new/
https://reviews.llvm.org/D89038
More information about the llvm-commits
mailing list